Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Two fixes for info_gan.md example Code #15323

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Two fixes for info_gan.md example Code #15323

merged 2 commits into from
Jul 10, 2019

Conversation

khdlr
Copy link
Contributor

@khdlr khdlr commented Jun 22, 2019

Description

Fix the InfoGan Tutorial.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:

Changes

  • Increment counter, to both enable discriminator training and fix MXBoard Logging
  • Change the LossG MXBoard Scalar to actually reflect g_error and not d_error

@khdlr khdlr requested a review from szha as a code owner June 22, 2019 08:32
@khdlr
Copy link
Contributor Author

khdlr commented Jun 22, 2019

As this is a very small fix for a tutorial, I did not open a JIRA issue. Please tell me in case I should do so.

wkcn
wkcn approved these changes Jun 22, 2019
View reviewed changes
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you : )

@Roshrini Roshrini added the pr-awaiting-review PR is waiting for code review label Jun 23, 2019
@roywei
Copy link
Member

roywei commented Jul 8, 2019

@cloud-oak could you trigger ci? thanks!

@khdlr khdlr closed this Jul 9, 2019
@khdlr khdlr reopened this Jul 9, 2019
@wkcn wkcn merged commit 7d4d1bc into apache:master Jul 10, 2019
@wkcn
Copy link
Member

wkcn commented Jul 10, 2019

Merged. Thank you: )

@khdlr khdlr deleted the patch-1 branch July 10, 2019 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roywei roywei roywei approved these changes

@wkcn wkcn wkcn approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khdlr @roywei @wkcn @Roshrini